Fix proxy panic when balancer has no targets#2977
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2977 +/- ##
==========================================
- Coverage 93.17% 93.17% -0.01%
==========================================
Files 43 43
Lines 4501 4499 -2
==========================================
- Hits 4194 4192 -2
Misses 189 189
Partials 118 118 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2976
This fixes a panic when a proxy balancer returns no target.
Built-in balancers can return
nilwhen the target list is empty, for example afterRemoveTargetremoves the last target.ProxyWithConfignow returns502 Bad Gatewaythrough the configured error handler instead of passing the nil target toproxyHTTPorproxyRaw.I also added a test for a custom balancer returning a target with a nil URL.
Tests pass with
go test ./... -count=1.